Skip to content

chore: Add tests for ClientTaskManager#650

Merged
kabir merged 1 commit intoa2aproject:mainfrom
tibisabau:chore/add-tests-client-task-manager
Feb 13, 2026
Merged

chore: Add tests for ClientTaskManager#650
kabir merged 1 commit intoa2aproject:mainfrom
tibisabau:chore/add-tests-client-task-manager

Conversation

@tibisabau
Copy link
Contributor

@tibisabau tibisabau commented Feb 13, 2026

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #305 🦕

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 13, 2026

Summary of Changes

Hello @tibisabau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness and reliability of the ClientTaskManager by introducing a comprehensive suite of unit tests. These tests cover various scenarios for task creation, updates, and event handling, ensuring the manager behaves correctly under different conditions. Additionally, a subtle bug related to the initialization of task history was addressed, preventing potential runtime errors and enhancing the stability of the client task management logic.

Highlights

  • Unit Test Coverage: Added extensive unit tests for the ClientTaskManager class to ensure its core functionalities work as expected across various scenarios.
  • Bug Fix: Resolved a potential NullPointerException in the updateWithMessage method of ClientTaskManager by ensuring the task history list is always properly initialized.
Changelog
  • client/base/src/main/java/io/a2a/client/ClientTaskManager.java
    • Ensured the history list in updateWithMessage is always initialized as a new ArrayList to prevent NullPointerException if task.history() returns null.
  • client/base/src/test/java/io/a2a/client/ClientTaskManagerTest.java
    • Introduced a new test class ClientTaskManagerTest to cover the ClientTaskManager.
    • Added tests for getCurrentTask, including error handling for cases where no current task is set.
    • Included tests for saveTaskEvent with initial task saving, status updates, artifact updates, and task creation if not existing.
    • Implemented tests for updateWithMessage to verify message addition, status message migration, and preservation of existing history.
    • Added tests for handling multiple sequential status and artifact updates.
    • Verified the correct handling of tasks with an empty contextId.
Activity
  • The pull request addresses and fixes issue [chore]: Add tests for ClientTaskManager #305.
  • The author, tibisabau, has followed the conventional commits specification for the pull request title.
  • The author has confirmed that all tests pass.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 13, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great addition. It adds a comprehensive test suite for ClientTaskManager, which significantly improves code quality and maintainability. The included fix in updateWithMessage is crucial, addressing a potential UnsupportedOperationException by correctly handling immutable collections. The new tests are well-written and cover a good range of scenarios.

@tibisabau tibisabau changed the title chore: Add tests for ClientTaskManager and fixes #305 chore: Add tests for ClientTaskManager Feb 13, 2026
@kabir kabir merged commit 7c10908 into a2aproject:main Feb 13, 2026
9 of 12 checks passed
@kabir
Copy link
Collaborator

kabir commented Feb 13, 2026

Thanks @tibisabau !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsavoie ehsavoie ehsavoie approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[chore]: Add tests for ClientTaskManager

3 participants

@tibisabau @kabir @ehsavoie